Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows + Visual Studio port #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tbennun
Copy link

@tbennun tbennun commented Jun 17, 2016

Here is my attempt to port nccl to Windows.
In the process, some concepts (e.g., atomic variables) were converted to C++11.

Unsupported features in Windows:

  • CUDA IPC memory (and thus MPI applications)
  • NVML "set processor affinity" functionality

Untested features:

  • shmOpen/Unlink/Unmap (because GPU IPC memory pointers aren't supported anyway)

…e converted to C++11 in the process.

Unsupported features in Windows:
  * CUDA IPC memory (and thus MPI applications)
  * NVML set processor affinity functionality

Incomplete/untested features:
  * shmOpen/Unlink/Unmap
@happynear
Copy link

Hi @tbennun ,

Could you update your repository to the latest version of the official repo?

@tbennun
Copy link
Author

tbennun commented Jan 19, 2017

Sure, I'll try to do it over the weekend.

@tbennun
Copy link
Author

tbennun commented Jan 20, 2017

@happynear Done, tested on Windows. Please make sure everything still works prior to the merge, I didn't get a chance to test this on a Linux machine.

@happynear
Copy link

Thanks:)

@pipipopo
Copy link

pipipopo commented Mar 1, 2017

Thanks for this contribution! I met a problem when compiling using VS2013 and CUDA 8.0, reads below:
/nccl-windows-master/src/all_gather.cu(180): error C2440: “type conversion”: cannot convert from “void (__cdecl *)(const KernelArgs)” to “void *”
May I know what's wrong?

@tbennun
Copy link
Author

tbennun commented Mar 1, 2017

@pipipopo I'm using VS2015 and don't observe this error.

The error seems to stem from src/common_coll.h, line 111. Try to play with the casting there (reinterpret_cast?) until it compiles.

@ZoroDerVonCodier
Copy link

Great work! works great using VS2015. The only suggestion that I would have is to add a VERSION resource to the project so as to better track versioning info with the master project.

minsii pushed a commit to minsii/nccl that referenced this pull request Nov 4, 2023
Summary: Pull Request resolved: facebookresearch#31

Reviewed By: cenzhaometa

Differential Revision: D50063012

Pulled By: kingchc

fbshipit-source-id: 9b64bee4639f3fd58764b953cd6d8f8274565af6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants