Explicitly use UnsafeLoader to load config/state #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR NVIDIA#22 merged an upgrade to PyYAML which broke our existing use of yaml.load for configuration and state files. Unfortunately, we can't use safe_load here because we make use of `defaultdict` datastructures that don't work with this method: ``` yaml.constructor.ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:python/object/apply:collections.defaultdict' ``` So this PR explicitly uses the UnsafeLoader to load the config and state files. This should be fine, as we're not accepting any arbitrary data from untrusted users for this configuration. Anyone who is using this tool has Docker access, so should be assumed to be an administrator anyway.
ryanolson
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #22 merged an upgrade to PyYAML which broke our existing use of
yaml.load for configuration and state files.
Unfortunately, we can't use safe_load here because we make use of
defaultdictdatastructures that don't work with this method:So this PR explicitly uses the UnsafeLoader to load the config and state
files.
This should be fine, as we're not accepting any arbitrary data
from untrusted users for this configuration. Anyone who is using this
tool has Docker access, so should be assumed to be an administrator
anyway.