Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake Cannot Locate git_revision.cuh file in nvbench/details #144

Closed
nv-rliu opened this issue Oct 19, 2023 · 2 comments · Fixed by #145
Closed

Cmake Cannot Locate git_revision.cuh file in nvbench/details #144

nv-rliu opened this issue Oct 19, 2023 · 2 comments · Fixed by #145
Assignees

Comments

@nv-rliu
Copy link

nv-rliu commented Oct 19, 2023

I'm trying to build nvbench by following the instructions in the README file.

After running cmake -DNVBench_ENABLE_EXAMPLES=ON -DCMAKE_CUDA_ARCHITECTURES=70 .. && make, I get this following error:

[ 30%] Building CXX object nvbench/CMakeFiles/nvbench.dir/named_values.cxx.o
[ 32%] Building CUDA object nvbench/CMakeFiles/nvbench.dir/option_parser.cu.o
In file included from /root/nvbench/nvbench/option_parser.cu:24:
/root/nvbench/nvbench/git_revision.cuh:21:10: fatal error: nvbench/detail/git_revision.cuh: No such file or directory
   21 | #include <nvbench/detail/git_revision.cuh>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [nvbench/CMakeFiles/nvbench.dir/build.make:265: nvbench/CMakeFiles/nvbench.dir/option_parser.cu.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:245: nvbench/CMakeFiles/nvbench.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

When I run find . -name git_revision.cuh I see that the only file with that name is inside nvbench/nvbench/git_revision.cuh. Why is there no git_revision.cuh file inside nvbench/details/?

@robertmaynard robertmaynard self-assigned this Oct 19, 2023
@robertmaynard
Copy link
Collaborator

Why is there no git_revision.cuh file inside nvbench/details/?

The git_revision.cuh should be generated at build time and placed in <build_dir>/nvbench/details/. The current issue is that in parallel builds the step that generates teh git_revision.cuh is not happening before consumers are built.

@nv-rliu
Copy link
Author

nv-rliu commented Oct 19, 2023

For now, I'm able to successfully build using commit 39b2770b62ce1f4e0ebeb9af60d7c6de624633a5
Hope this helps anyone else who encounters this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants