This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
Support for openSUSE Leap 15.1 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
It gives the opportunity to perform cleanup in the main function.
Any environment variable with the prefix "NVIDIA_REQUIRE_" will have its value passed to nvidia-container-cli. NVIDIA_CUDA_VERSION is no longer used and the CUDA images will be replaced by a NVIDIA_REQUIRE_CUDA variable. Those checks can be disabled globally in the configuration file or for each container using NVIDIA_DISABLE_REQUIRE.
Ensure base-builder stage only runs when base dockerfiles are changed See merge request nvidia/container-toolkit/nvidia-container-runtime!14
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
Add XDG override for config directory See merge request nvidia/container-toolkit/nvidia-container-runtime!15
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
Add initial runtime container See merge request nvidia/container-toolkit/nvidia-container-runtime!16
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
Update default runtime configuration See merge request nvidia/container-toolkit/nvidia-container-runtime!17
dev-zero
added a commit
to dev-zero/nvidia-docker
that referenced
this pull request
Aug 14, 2019
This requires support for openSUSE in the nvidia-container-runtime, see: NVIDIA/nvidia-container-runtime#32 Fixes NVIDIA#657 Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
dev-zero
added a commit
to dev-zero/nvidia-docker
that referenced
this pull request
Aug 14, 2019
This requires support for openSUSE in the nvidia-container-runtime, see: NVIDIA/nvidia-container-runtime#32 Fixes NVIDIA#657 Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
dev-zero
force-pushed
the
opensuse-support
branch
2 times, most recently
from
2d2d533
to
f5cdc80
Compare
|
@RenaudWasTaken thanks for the extensive explanation. Being at the boundary of corporate and open source can be quiet stressful, I get that. It is nice to see more activity again. |
dev-zero
added a commit
to dev-zero/nvidia-docker
that referenced
this pull request
Aug 14, 2019
This requires support for openSUSE in the nvidia-container-runtime, see: NVIDIA/nvidia-container-runtime#32 Fixes NVIDIA#657 Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
|
also in this PR did I now switch from using |
jjacobelli
suggested changes
Aug 16, 2019
runtime/Dockerfile.opensuse-leap
Outdated
| @@ -0,0 +1,38 @@ | |||
| ARG BASE | |||
| ARG VERSION_ID | |||
| FROM nvidia/base/opensuse-leap:${VERSION_ID} | |||
There was a problem hiding this comment.
You should use the BASE argument here
dev-zero
added a commit
to dev-zero/nvidia-docker
that referenced
this pull request
Aug 23, 2019
This requires support for openSUSE in the nvidia-container-runtime, see: NVIDIA/nvidia-container-runtime#32 Fixes NVIDIA#657 Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
RenaudWasTaken
pushed a commit
to NVIDIA/nvidia-docker
that referenced
this pull request
Aug 23, 2019
This requires support for openSUSE in the nvidia-container-runtime, see: NVIDIA/nvidia-container-runtime#32 Fixes #657 Signed-off-by: Tiziano Müller <tiziano.mueller@chem.uzh.ch>
|
I'm not sure what happened with this PR? |
|
Merged: de70c3f ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.