Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-relnote] Fix release tooling #601

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

elezar
Copy link
Member

@elezar elezar commented Jul 10, 2024

No description provided.

@elezar elezar self-assigned this Jul 10, 2024
hack/prepare-artifacts.sh Outdated Show resolved Hide resolved
hack/create-release.sh Outdated Show resolved Hide resolved
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested all the bash bits, can't test the gh bits since it doesn't provide a dry run option. But PR looks good

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar merged commit fce56f9 into NVIDIA:main Jul 11, 2024
8 checks passed
@elezar elezar deleted the post-release-tooling-fix branch July 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants