Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables #24

Closed
wants to merge 1 commit into from
Closed

Remove unused variables #24

wants to merge 1 commit into from

Conversation

aqk
Copy link

@aqk aqk commented May 12, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@6543 6543 mentioned this pull request May 12, 2022
Open
@aqk aqk mentioned this pull request May 12, 2022
Closed
samiurprapon
samiurprapon approved these changes May 12, 2022
View reviewed changes
Copy link

@samiurprapon samiurprapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, no usage of those variables

@baryluk
Copy link

baryluk commented May 12, 2022

LGTM

@DMaroo DMaroo mentioned this pull request May 14, 2022
Closed
@mtijanic
Copy link
Collaborator

Thank you for the PR, but marking as cosmetic-postponed for now. Please see #190 for details.

@mtijanic mtijanic added cosmetic-postponed A cosmetic-only change, which we've prioritized below other changes. labels May 14, 2022
@niv
Copy link
Member

niv commented Jul 7, 2022

It is likely that these variables are actually used; just not in the parts that are currently open-sourced. Some parts of the code are removed before publishing to GH. Thus, what you are looking at is more of a transformation artefact. I agree that it's not pretty.

That said:

Thank you for your interest in contributing to open-gpu-kernel-modules.

As recently explained in CONTRIBUTING.md, we have decided to not accept cosmetic changes for now.

All changes going into this repository incur significant overhead on our end, and we'd like to focus our resources on executable code changes; so we have decided to close all PRs that make no code changes.

If and when this position changes, your PR will still be in the archives and revisited (as long as it's still tagged cosmetic-postponed).

Please do not feel discouraged to submit other changes! In addition, we will be happy to keep the conversation going on the Discussion boards here on GitHub, and elsewhere.

@niv niv closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiurprapon samiurprapon samiurprapon approved these changes

Assignees
No one assigned
Labels
cosmetic-postponed A cosmetic-only change, which we've prioritized below other changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aqk @CLAassistant @baryluk @mtijanic @niv @samiurprapon