Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set INSTALL_MOD_DIR only if it's not defined #570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keelung-yang
Copy link

@keelung-yang keelung-yang commented Nov 1, 2023

As described in Compiling the Kernel (Kernel 5.15) section of NVIDIA DRIVE OS Linux SDK Developer Guide v6.0.8.1, nvidia*.ko are copied into extra/opensrc-disp manually:

mkdir -p $NV_WORKSPACE/drive-linux/kernel/source/oss_src/out-linux/lib/modules/<kernel_version>/extra/opensrc-disp/
cd kernel-open
cp nvidia.ko nvidia-modeset.ko nvidia-drm.ko $NV_WORKSPACE/drive-linux/kernel/source/oss_src/out-linux/lib/modules/<kernel_version>/extra/opensrc-disp/

So, the INSTALL_MOD_DIR should be set to extra/opensrc-disp at least in DriveOS 6.0.8.1 if make modules_install is used instead of copying them manually.

But in kernel-open/Makefile, INSTALL_MOD_DIR is set to kernel/drivers/video forcefully:

KBUILD_PARAMS += INSTALL_MOD_DIR=kernel/drivers/video

So INSTALL_MOD_DIR should be set only if it's not specified, such as INSTALL_MOD_DIR=extra/opensrc-disp make modules_install should works if users want to install them into another directory but kernel/drivers/video.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants