Skip to content

Commit

Permalink
pfs_middleware: drop X-Object-Manifest on POST
Browse files Browse the repository at this point in the history
I thought this was preserved like X-Static-Large-Object, but it's
actually treated like object metadata by Swift.
  • Loading branch information
smerritt committed Nov 16, 2017
1 parent 8b2a218 commit 5de4b2d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion pfs_middleware/pfs_middleware/middleware.py
Expand Up @@ -129,7 +129,6 @@

# These are not mutated on object POST.
STICKY_OBJECT_METADATA_HEADERS = {
"X-Object-Manifest",
"X-Static-Large-Object",
ORIGINAL_MD5_HEADER}

Expand Down
2 changes: 1 addition & 1 deletion pfs_middleware/tests/test_pfs_middleware.py
Expand Up @@ -2498,8 +2498,8 @@ def mock_RpcHead(_):
self.assertEqual(new_meta["Content-Type"], "application/fishy")
self.assertEqual(new_meta["X-Object-Sysmeta-Dog"], "collie")
self.assertEqual(new_meta["X-Static-Large-Object"], "true")
self.assertEqual(new_meta["X-Object-Manifest"], "solo/duet")
self.assertEqual(new_meta["X-Object-Meta-Fish"], "trout")
self.assertNotIn("X-Object-Manifest", new_meta)

def test_change_content_type(self):
old_meta = json.dumps({"Content-Type": "old/type"})
Expand Down

0 comments on commit 5de4b2d

Please sign in to comment.