Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine cupsatial demo to make it more clear for customers #187

Merged
merged 66 commits into from
Jul 19, 2022

Conversation

nvliyuan
Copy link
Collaborator

@nvliyuan nvliyuan commented Jun 24, 2022

refine cupsatial demo to make it more clear for customers

  • update cuda pub key to avoid GPG error in databricks docker file
  • update performance target to a specific dataset
  • add more comments about how to build/run
  • add cpu version notebook base on Apache Sedona

Signed-off-by: liyuan yuali@nvidia.com

Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan nvliyuan changed the title refine cupsatial demo to make it more clear for customers [WIP]refine cupsatial demo to make it more clear for customers Jun 24, 2022
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan nvliyuan changed the title [WIP]refine cupsatial demo to make it more clear for customers refine cupsatial demo to make it more clear for customers Jul 4, 2022
@nvliyuan nvliyuan marked this pull request as ready for review July 4, 2022 06:28
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command docker build -f Dockerfile . -t build-spark-cuspatial on line 44 is failing. I get the following:

ERROR conda.cli.main_run:execute(49): `conda run /bin/bash -c conda install -c rapidsai-nightly -c nvidia -c conda-forge -c defaults libcuspatial=22.06 python=3.8 -y` failed. (See above for error)

Is this failing because we are mixing 22.06 and 22.08-SNAPSHOT?

Detailed error in https://gist.github.com/sameerz/544c046bf0b13683288df846d5d5673f

Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Jul 5, 2022

Detailed error in https://gist.github.com/sameerz/544c046bf0b13683288df846d5d5673f

yes, I can reproduce it by running docker build without cache, update the docker file

@sameerz
Copy link
Collaborator

sameerz commented Jul 5, 2022

Detailed error in https://gist.github.com/sameerz/544c046bf0b13683288df846d5d5673f

yes, I can reproduce it by running docker build without cache, update the docker file

I can build the docker file now and was able to build the spark-cuspatial-22.08.0-SNAPSHOT.jar.

Do we want to update lines 66-69 in README.md to refer to 22.06 and 22.08-SNAPSHOT instead of 22.04 and 22.06-SNAPSHOT?

Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Jul 5, 2022

Do we want to update lines 66-69 in README.md to refer to 22.06 and 22.08-SNAPSHOT instead of 22.04 and 22.06-SNAPSHOT?

updated, thanks

Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Jul 8, 2022

Add CPU notebook run on databricks

@nvliyuan nvliyuan requested a review from sameerz July 8, 2022 15:48
Co-authored-by: Liangcai Li <firestarmanllc@gmail.com>
@nvliyuan nvliyuan requested a review from NvTimLiu July 11, 2022 02:37
nvliyuan and others added 24 commits July 15, 2022 13:45
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Co-authored-by: Hao Zhu <9665750+viadea@users.noreply.github.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
@viadea viadea self-requested a review July 18, 2022 17:16
viadea
viadea previously approved these changes Jul 18, 2022
Signed-off-by: liyuan <yuali@nvidia.com>
@nvliyuan nvliyuan merged commit 8c4809c into NVIDIA:branch-22.08 Jul 19, 2022
@nvliyuan nvliyuan deleted the cuspatial-refine branch December 20, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants