Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] disable collect_list and collect_set for window operations by default. #10110

Closed
revans2 opened this issue Dec 28, 2023 · 0 comments · Fixed by #10132
Closed

[BUG] disable collect_list and collect_set for window operations by default. #10110

revans2 opened this issue Dec 28, 2023 · 0 comments · Fixed by #10132
Assignees
@revans2
Labels
bug Something isn't working reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Dec 28, 2023

Describe the bug
collect_list and collect_set in a window context are going to make memory explode (the size of the window squared). collect_set right now is implemented in terms of collect_list and a dedupe stage. So with how we are currently doing window operations there is no good way to try and make collect_list or collect_set work in the context of a window. We should disable them by default until we have a better solution.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Dec 28, 2023
This was referenced Dec 28, 2023
Open
Open
@revans2 revans2 self-assigned this Dec 29, 2023
@revans2 revans2 mentioned this issue Dec 29, 2023
Merged
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable collect_list and collect_set for window by default revans2/spark-rapids
2 participants
@revans2 @sameerz