Disable collect_list and collect_set for window by default #10132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
|
The link checker is having problems with the release in progress. |
jlowe
previously approved these changes
Dec 29, 2023
| .doc("The output size of collect list for a window operation is proportional to " + | ||
| "the window size squared. The current GPU implementation does not handle this well " + | ||
| "and is disabled by default. If you know that your window size is very small you " + | ||
| "can try to enable it") |
There was a problem hiding this comment.
Suggested change
| "can try to enable it") | |
| "can try to enable it.") |
| .doc("The output size of collect set for a window operation can be proportional to " + | ||
| "the window size squared. The current GPU implementation does not handle this well " + | ||
| "and is disabled by default. If you know that your window size is very small you " + | ||
| "can try to enable it") |
There was a problem hiding this comment.
Suggested change
| "can try to enable it") | |
| "can try to enable it.") |
|
build |
|
@jlowe please take another look |
jlowe
approved these changes
Jan 2, 2024
mattahrens
added
the
reliability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10110