Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU supports yyyyMMdd format by post process for the from_unixtime function #10023

Merged
merged 1 commit into from
Dec 13, 2023
Merged

GPU supports yyyyMMdd format by post process for the from_unixtime function #10023

merged 1 commit into from
Dec 13, 2023

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Dec 12, 2023 •
edited

fixes #8807

This PR adds in the support of 'yyyyMMdd' format for GpuFromUnixTime by a post conversion in Plugin. Since cuDF does not support this format by default.

NOTE: This is a short-term solution and the better fix is to support this format in cuDF.

@firestarman
GpuFromUnixTime supports more formats by post process
2503cd5 
Support format 'yyyyMMdd' for GpuFromUnixTime

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

revans2
revans2 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, the performance looks good, but I really don't like it. I think long term we are going to have to write our own kernel for all of this. So I filed #10032

@firestarman firestarman merged commit b309f70 into NVIDIA:branch-24.02 Dec 13, 2023
38 of 39 checks passed
@firestarman firestarman deleted the more_format_unixtime branch December 13, 2023 01:09
@firestarman
Copy link
Collaborator Author

firestarman commented Dec 13, 2023 •
edited

I think long term we are going to have to write our own kernel for all of this.

Absolutely agree

@sameerz sameerz added the feature request New feature or request label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winningsix winningsix winningsix approved these changes

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] support ‘yyyyMMdd’ format in from_unixtime function
4 participants
@firestarman @winningsix @revans2 @sameerz