Fix failed cases for non-utc time zone #10060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
build |
1 similar comment
|
build |
thirtiseven
previously approved these changes
Dec 18, 2023
winningsix
previously approved these changes
Dec 18, 2023
res-life
dismissed stale reviews from winningsix and thirtiseven
via
c246de4
|
build |
winningsix
reviewed
Dec 19, 2023
| To run with non-UTC time zone, set TZ environment variable, | ||
| For example: | ||
| ```shell | ||
| $ TZ=Iran ./integration_tests/run_pyspark_from_build.sh |
There was a problem hiding this comment.
I think it could be better to cover other timezones at least one case for DST.
|
build |
winningsix
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10055
The 2 failed cases were added recently.
Because premerge does not cover all the cases for non-utc, so it passed in premerge, but failed in nightly CI.
Add
ProjectExectonon_utc_allowto fix.Signed-off-by: Chong Gao res_life@163.com