Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fix date format failed cases for non-UTC time zone. #10095

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Dec 26, 2023

Related to #10083

When time zone is non-UTC, formating timestamp column which contains 9999-12-31 time will do the following:

  • step1: rebase from microseconds of 9999-12-31 to the microseconds of 10000-01-01 according to non-UTC tz.
  • step2: use cuDF to format 10000 years to get the strings.
    In the above step 2, cuDF has limitation, it truncate 10000 to 0000
    Refer to link, cuDF supports %Y has a 4 digits length.
specifier_map specifiers = {
    {'Y', 4}, {'y', 2}, {'m', 2}, {'d', 2}, {'H', 2}, {'I', 2}, {'M', 2},
// will truncate `10000` to `0000`
cv.asStrings("%Y-%m-%d")

This PR is a workaround to temporarily fix this issue.
After we have a new kernel to handle Java time format, we then revert this PR.

Signed-off-by: Chong Gao res_life@163.com

Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

build

@res-life res-life merged commit 0a339de into NVIDIA:branch-24.02 Dec 26, 2023
39 of 40 checks passed
@sameerz sameerz added the bug Something isn't working label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants