Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isFailed() to MockTaskContext and Remove MockTaskContextBase.scala [databricks] #10106

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Add isFailed() to MockTaskContext and Remove MockTaskContextBase.scala [databricks] #10106

merged 4 commits into from
Dec 29, 2023

Conversation

razajafri
Copy link
Collaborator

This PR removes the MockContextBase and instead adds a method to MockTaskContext.scala

@razajafri
Copy link
Collaborator Author

@gerashegalov PTAL

This should go in after #9967 because the premerge on that has almost completed

gerashegalov
gerashegalov previously approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razajafri
Copy link
Collaborator Author

build

@razajafri
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit 7c861f1 into NVIDIA:branch-24.02 Dec 29, 2023
40 checks passed
@razajafri razajafri deleted the remove-MockTaskContextBase branch December 29, 2023 19:59
@sameerz sameerz added audit_3.5.1 Audit related tasks for 3.5.1 Spark 3.5+ Spark 3.5+ issues labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes

Assignees
No one assigned
Labels
audit_3.5.1 Audit related tasks for 3.5.1 Spark 3.5+ Spark 3.5+ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@razajafri @gerashegalov @sameerz