Deterministic ordering in window tests #10205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#10195. This is similar to the fix in NVIDIA#10143. This commit changes the test datagens used in the window function tests such that the order-by columns produce deterministic ordering. When the ordering is ambiguous, it can produce unexpected results from window functions, if the `order-by` spec includes the ambiguous columns. Signed-off-by: MithunR <mythrocks@gmail.com>
|
Build |
jlowe
reviewed
Jan 17, 2024
| @@ -57,17 +57,17 @@ | |||
| _grpkey_longs_with_decimals = [ | |||
| ('a', RepeatSeqGen(LongGen(nullable=False), length=20)), | |||
| ('b', DecimalGen(precision=18, scale=3, nullable=False)), | |||
| ('c', DecimalGen(precision=18, scale=3))] | |||
There was a problem hiding this comment.
Previously the key was a decimal but now it's a long, so are we losing test coverage with this change or are we not worried about that here?
There was a problem hiding this comment.
Should we make a UniqueIntegerGen and a UniqueDecimalGen too then?
There was a problem hiding this comment.
@jlowe, I did consider that lost coverage. There's a couple of things working in favour of this change:
- Note that in the tests that use these gens, the query orders by both
bandc, both beingDecimalGen. We're only changingc, so the test still orders byDECIMAL. I don't think we're losing coverage. - The focus of the
negative_rowstest is on whether row offsets< 0work. It isn't really affected much by the order-by column, as with Fixtest_window_aggs_for_batched_finite_row_windows_partitionedfail #10143.
There was a problem hiding this comment.
@revans2, we could consider introducing a UniqueDecimalGen, but I don't think that's strictly necessary for this test.
I'm open to adding it, if you think it's wise.
jlowe
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10195.
This is similar to the fix in #10143. This commit changes the test datagens used in the window function tests such that the order-by columns produce deterministic ordering.
When the ordering is ambiguous, it can produce unexpected results from window functions, if the
order-byspec includes the ambiguous columns.