Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support barrier mode for mapInPandas/mapInArrow (#10343)" #10355

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

wbo4958
Copy link
Collaborator

@wbo4958 wbo4958 commented Feb 1, 2024

Fixes #10359.

This reverts commit 6723a68, which seems to have caused a compile error on Databricks:

01:49:20  [ERROR] /home/ubuntu/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala:70: object GpuMapInPandasExecMeta is not a member of package org.apache.spark.sql.rapids.shims
01:49:20  [ERROR] import org.apache.spark.sql.rapids.shims.{GpuAscii, GpuMapInPandasExecMeta, GpuTimeAdd}
01:49:20  [ERROR]        ^
01:49:22  [ERROR] /home/ubuntu/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala:4356: not found: type GpuMapInPandasExecMeta
01:49:22  [ERROR]       (mapPy, conf, p, r) => new GpuMapInPandasExecMeta(mapPy, conf, p, r)),

This reverts commit 6723a68.

Signed-off-by: Bobby Wang <wbo4958@gmail.com>
@jlowe
Copy link
Member

jlowe commented Feb 1, 2024

build

@jlowe
Copy link
Member

jlowe commented Feb 1, 2024

@wbo4958 It would be nice to have a blurb in the PR description explaining why we're doing this, otherwise team members have to dig to try to figure out why we would want this and what issue it solves to do so.

@jlowe
Copy link
Member

jlowe commented Feb 1, 2024

build

@mythrocks
Copy link
Collaborator

Pardon me, I've taken the liberty to add some context to the description.

@jlowe jlowe merged commit 6c54f5d into NVIDIA:branch-24.02 Feb 1, 2024
39 of 40 checks passed
@wbo4958
Copy link
Collaborator Author

wbo4958 commented Feb 1, 2024

Hi @jlowe, I got the info from @GaryShen2008 that 24.02 branch was burned down, so I reverted this PR in 24.02 and will merge it in 24.04. Sorry for the trouble.

@sameerz
Copy link
Collaborator

sameerz commented Feb 2, 2024

@wbo4958 do we need to reopen the original issue #10344 and retarget it to 24.04?

@wbo4958
Copy link
Collaborator Author

wbo4958 commented Feb 2, 2024

@wbo4958 do we need to reopen the original issue #10344 and retarget it to 24.04?

Yeah, I've just opened it.

@sameerz sameerz added the bug Something isn't working label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Build failure on Databricks nightly run with GpuMapInPandasExecMeta
5 participants