Enable Single Quote Support in getJSONObject API with GetJsonObjectOptions #10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
revans2
reviewed
Feb 12, 2024
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
SurajAralihalli
commented
Feb 12, 2024
| @@ -50,6 +50,19 @@ def test_get_json_object_quoted_index(): | |||
| f.get_json_object('jsonStr',r'''$['b']''').alias('sub_b')), | |||
| conf={'spark.rapids.sql.expression.GetJsonObject': 'true'}) | |||
|
|
|||
| def test_get_json_object_single_quotes(): | |||
There was a problem hiding this comment.
@revans2 Added test_get_json_object_single_quotes. This test would fail when .allowSingleQuotes(false).
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue 10219
Depends on Cudf PR 14956
The PR 14956 adds
GetJsonObjectOptionsto thegetJSONObjectAPI. By default, single quote support is turned off. This pull request enables the single quote option in all instances ofgetJSONObjectby including the options argument in the function call.Note: PR 14956 ensures backward compatibility, allowing this PR to be merged at any time following the completion of PR 14956.