Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid comparing Delta logs when writing partitioned tables #10415

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Feb 12, 2024

Fixes #10410. When writing partitioned tables there's no guarantee on task partitioning due to the random sampling of input data. This causes Delta log metadata checking to fail because not all of the same records are sent to the same tasks and thus not all the same records end up in a corresponding file between runs. Therefore we can't check record counts, null counts, statistics, etc. and thus we just skip metadata checking when writing to a partitioned table.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Feb 12, 2024
@jlowe jlowe self-assigned this Feb 12, 2024
@jlowe
Copy link
Member Author

jlowe commented Feb 12, 2024

build

@jlowe jlowe merged commit 31773cb into NVIDIA:branch-24.04 Feb 13, 2024
40 of 41 checks passed
@jlowe jlowe deleted the fix-delta-update-partitioned-tests branch February 13, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
2 participants