Enable GpuShuffledSymmetricHashJoin by default #10418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
previously approved these changes
Feb 13, 2024
| Table.mixedInnerJoinGatherMaps(leftKeys, rightKeys, leftTable, rightTable, | ||
| compiledCondition, nullEquality) | ||
| case _: InnerLike if buildSide == GpuBuildLeft => |
There was a problem hiding this comment.
nit: Should we update the error message in the exception to include the build side?
|
build |
|
build |
revans2
approved these changes
Feb 15, 2024
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10243. Turns on the new symmetric hash join exec by default and fixes a few bugs that were found. One was a double-close bug, and the other is a incorrect binding of a join condition expression. This binding order bug also existed in the original GpuHashJoin code, so I fixed it there as well (and verified tests pass even if we disable symmetric hash join).