Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix table rendering issue in github.io download UI page [skip ci] #10449

Merged

Conversation

SurajAralihalli
Copy link
Collaborator

This PR fixes the table rendering issue in Github UI and fixes broken links.

UI: Download page

signed-off-by: Suraj Aralihalli suraj.ara16@gmail.com

Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@viadea
Copy link
Collaborator

viadea commented Feb 20, 2024

build

@SurajAralihalli SurajAralihalli merged commit 6ec5302 into NVIDIA:branch-24.04 Feb 21, 2024
40 of 41 checks passed
@jlowe
Copy link
Member

jlowe commented Feb 21, 2024

This should have targeted branch-24.02.

@SurajAralihalli
Copy link
Collaborator Author

Thanks Jason and @viadea for pointing this out! Once version 24.02 is released, do we still direct documentation patches to that branch? I believed in that scenario updating 24.04 and main would be sufficient.

@jlowe
Copy link
Member

jlowe commented Feb 21, 2024

24.02 is not released yet, and the docs on branch-24.02 have the same issue, hence why we would want it fixed there. But yes, if 24.02 had been released then we don't necessarily want to back-patch it but instead patch it going forward. Given we're so close to releasing, it gets in that "gray area" where it's not always clear where it should go.

@SurajAralihalli
Copy link
Collaborator Author

Got it, I'll have it fixed in 24.02 as well, Thanks!

@sameerz sameerz added the documentation Improvements or additions to documentation label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants