Remove Support for Databricks 10.4 [databricks] #10474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Liu <timl@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
razajafri
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
jlowe
reviewed
Feb 22, 2024
...gen/src/main/spark320/scala/org/apache/spark/sql/tests/datagen/datagen/DataGenExprBase.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark311/scala/org/apache/spark/sql/rapids/shims/GpuAscii.scala
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,6 @@ | |||
| #!/usr/local/env groovy | |||
| /* | |||
| * Copyright (c) 2023, NVIDIA CORPORATION. | |||
| * Copyright (c) 2023-2024, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Check copyrights in every file. Since you haven't used the pre-commit, the easiest is probably to run
./scripts/auto-copyrighter.sh $(git diff --name-only origin/branch-24.04..HEAD)There was a problem hiding this comment.
Thanks! My pre-commit is broken somehow and I assumed it ran.
|
This should've been a draft PR PTAL again |
jlowe
approved these changes
Feb 23, 2024
|
build |
gerashegalov
approved these changes
Feb 23, 2024
| @@ -24,7 +24,7 @@ import org.apache.spark.sql.rapids.shims.ArrowUtilsShim | |||
| import org.apache.spark.sql.types._ | |||
| import org.apache.spark.sql.vectorized.ColumnarBatch | |||
|
|
|||
| //TODO is this needed? we already have a similar version in spark321db | |||
| //TODO is this needed? we already have a similar version in spark330db | |||
There was a problem hiding this comment.
If you'll have to run CI another time, please drop this obsolete comment beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for Databricsk 10.4
Changes:
mvn generate-sources -Dshimplify=true -Dshimplify.move=true -Dshimplify.remove.shim=321db, fixed up some unnecessary empty lines that were introduced.Tests:
fixes #10429