Fix scalar leak in SumBinaryFixer (#10510) #10513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Brennan <jimb@nvidia.com>
jbrennan333
added
bug
jlowe
approved these changes
Feb 28, 2024
|
build |
1 similar comment
|
build |
abellina
approved these changes
Feb 28, 2024
|
For context, this bug looks like it was introduced by #4272, which went into 22.02, so this leak has been there for quite some time. |
|
As a validation, I ran nds power run at scale 100 and verified there were no errors, and the output data was correct. |
|
I am ok with this going into 24.02 late, as it is a relatively small fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #10510, which went into 24.04.
I am putting this up in case we want to merge this in 24.02 at this point?