Update CI script to build and deploy using the same CUDA classifier[skip ci] #10598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
gerashegalov
as code owners
Update CI script to support building and deploying using the same CUDA classifier Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
force-pushed
the
update-ci-script
branch
from
1cccae7
to
c34efdd
Compare
NvTimLiu
changed the title
|
[skip ci] to skip pre-merge CI, as this script can not be executed in pre-merge CI jobs |
|
build |
jlowe
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CI script to support building and deploying using the same CUDA classifier:
Currently our deploy.sh always try to upload cuda.version(default cuda11) jars by default, due to DEFAULT_CUDA_CLASSIFIER always be overwrite here.
We can set DEFAULT_CUDA_CLASSIFIER=cuda12 to only build cuda12 jar DEFAULT_CUDA_CLASSIFIER=${DEFAULT_CUDA_CLASSIFIER:-$(mvnEval cuda.version)} # default cuda version
So we should only upload cuda12 jar also by set DEFAULT_CUDA_CLASSIFIER=cuda12 and not overwrite it by cuda11