Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to 3.1.0 maven-gpg-plugin in deploy script [skip ci] #10625

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

NvTimLiu
Copy link
Collaborator

To fix: #10624

As latest maven-gpg-plugin has the issue "error 401 Unauthorized"

when deploy files onto Sonatype repo, we pin it to the

stable version 3.1.0 to unblock our release process.

To fix: NVIDIA#10624

As latest maven-gpg-plugin has the issue "error 401 Unauthorized"

when deploy files onto Sonatype repo, we pin it to the

stable version 3.1.0 to unblock our release process.

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Mar 22, 2024
@NvTimLiu NvTimLiu self-assigned this Mar 22, 2024
@NvTimLiu NvTimLiu changed the title Pin to 3.1.0 maven-gpg-plugin in deploy script Pin to 3.1.0 maven-gpg-plugin in deploy script [skip ci] Mar 22, 2024
@NvTimLiu NvTimLiu marked this pull request as draft March 24, 2024 14:55
@NvTimLiu
Copy link
Collaborator Author

3.1.0 maven-gpg-plugin has the same "401 Unauthorized" now.

Draft this PR until we maven-gpg-plugin fixed the issue, or we need a work around for deploy.

@NvTimLiu
Copy link
Collaborator Author

3.1.0 maven-gpg-plugin has the same "401 Unauthorized" now.

Draft this PR until we maven-gpg-plugin fixed the issue, or we need a work around for deploy.

Seems like maven-gpg-plugin:3.1.0 or its dependency jars had intermittent errors, but now it works again!

@NvTimLiu NvTimLiu marked this pull request as ready for review March 25, 2024 02:53
@sameerz
Copy link
Collaborator

sameerz commented Mar 26, 2024

3.1.0 maven-gpg-plugin has the same "401 Unauthorized" now.
Draft this PR until we maven-gpg-plugin fixed the issue, or we need a work around for deploy.

Seems like maven-gpg-plugin:3.1.0 or its dependency jars had intermittent errors, but now it works again!

Is this PR still required?

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Apr 1, 2024

3.1.0 maven-gpg-plugin has the same "401 Unauthorized" now.
Draft this PR until we maven-gpg-plugin fixed the issue, or we need a work around for deploy.

Seems like maven-gpg-plugin:3.1.0 or its dependency jars had intermittent errors, but now it works again!

Is this PR still required?

@sameerz Yes this PR is still required.

Just checked Sonaytpe status, the intermittent 401 for 3.1.0 problem was from maven-gpg-plugin:3.1.0, but from SONATYPE itself, as not any maven-gpg-plugin version worked that day(but resumed later the second day). Sonatype Incident

image

So 3.1.0 of maven-gpg-plugin is still stable!

We should use the 3.1.0 as the stable fixed version in our deploy script instead of always use the latest version, until dependency/compatible issue appears(maybe due to integration of many new versions later), as we're not sure whether latest version has any issue or not.

@sameerz
Copy link
Collaborator

sameerz commented Apr 1, 2024

build

@NvTimLiu NvTimLiu merged commit 9415a51 into NVIDIA:branch-24.04 Apr 2, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deploy script "gpg:sign-and-deploy-file failed: 401 Unauthorized
3 participants