Use ErrorClass to Throw AnalysisException [databricks] #10830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
changed the title
jlowe
reviewed
May 17, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/hive/rapids/RapidsHiveErrors.scala
Outdated
Show resolved
Hide resolved
razajafri
changed the title
|
@jlowe I think I have addressed all your concerns |
jlowe
reviewed
May 21, 2024
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDataWritingCommandExec.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
requested review from
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
This reverts commit 0f765c9.
jlowe
reviewed
May 23, 2024
...plugin/src/main/scala/org/apache/spark/sql/rapids/GpuInsertIntoHadoopFsRelationCommand.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/TrampolineUtil.scala
Outdated
Show resolved
Hide resolved
...plugin/src/main/spark311/scala/org/apache/spark/sql/rapids/shims/RapidsQueryErrorUtils.scala
Show resolved
Hide resolved
razajafri
commented
May 31, 2024
...n/src/main/spark340/scala/org/apache/spark/sql/rapids/shims/RapidsErrorUtilsFor340Plus.scala
Outdated
Show resolved
Hide resolved
|
I have addressed all your concerns I think PTAL. |
|
build |
jlowe
reviewed
Jun 3, 2024
...plugin/src/main/scala/org/apache/spark/sql/rapids/GpuInsertIntoHadoopFsRelationCommand.scala
Outdated
Show resolved
Hide resolved
...n/src/main/scala/org/apache/spark/sql/rapids/catalyst/expressions/GpuRandomExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/TrampolineUtil.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark332db/scala/org/apache/spark/sql/rapids/GpuFileFormatWriter.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark400/scala/org/apache/spark/sql/rapids/shims/RapidsErrorUtils.scala
Outdated
Show resolved
Hide resolved
|
I have addressed your comments I think.
|
jlowe
reviewed
Jun 3, 2024
| * AnalysisException is thrown directly rather than via an error | ||
| * utility class (this should be rare). | ||
| */ | ||
| def throwRapidsAnalysisException(msg: String) = throw new RapidsAnalysisException(msg) |
There was a problem hiding this comment.
I'm not sure why we need a TrampolineUtil method to use one of our own classes. Why not have the class that would use this method simply throw RapidsAnalysisException directly?
There was a problem hiding this comment.
We don't need a TrampolineUtil method, this was a remnant of throwing the AnalysisException.
There was a problem hiding this comment.
Let me get rid of that. Please let me know if there are any other concerns
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Spark 4.0.0 the constructor of AnalysisException that takes a String parameter has been protected. To incorporate this change, we are introducing a shim class that will throw the respective errorClass
contributes to #9259