Catch exceptions when trying to examine Iceberg scan for metadata queries #10836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
1 similar comment
|
build |
revans2
approved these changes
May 17, 2024
|
issue for tracking regression testing incompatible Iceberg versions: #10837 |
wjxiz1992
pushed a commit
to nvliyuan/yuali-spark-rapids
that referenced
this pull request
May 21, 2024
* A hacky approach for regexpr rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Use contains instead for that case Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * add config to switch Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Rewrite some rlike expression to StartsWith/EndsWith/Contains Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Draft code to adapt RegexParser in regex rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Apply suggestions from code review Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> * A checkpoint before removing endsWith rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Remove equalsTo and endsWith Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * address a comment Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * address a comment Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * address comments Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * fix 2.13 build Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * checkpoint before pattern matching => if Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Add prefix range in regex parser rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Address comments Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * wip Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * change some names Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * checkpoint before upmerge Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * add tests Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Catch exceptions when trying to examine Iceberg scan for metadata queries (NVIDIA#10836) Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add NVTX ranges to identify Spark stages and tasks (NVIDIA#10826) * Add NVTX ranges to identify Spark stages and tasks Signed-off-by: Jason Lowe <jlowe@nvidia.com> * scalastyle --------- Signed-off-by: Jason Lowe <jlowe@nvidia.com> --------- Signed-off-by: Haoyang Li <haoyangl@nvidia.com> Signed-off-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
May 30, 2024
…IDIA#8) * A hacky approach for regexpr rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Use contains instead for that case Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * add config to switch Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Rewrite some rlike expression to StartsWith/EndsWith/Contains Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Draft code to adapt RegexParser in regex rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Apply suggestions from code review Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> * A checkpoint before removing endsWith rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Remove equalsTo and endsWith Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * address a comment Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * address a comment Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * address comments Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * fix 2.13 build Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * checkpoint before pattern matching => if Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Add prefix range in regex parser rewrite Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Address comments Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * wip Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * clean up Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * change some names Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * checkpoint before upmerge Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * add tests Signed-off-by: Haoyang Li <haoyangl@nvidia.com> * Catch exceptions when trying to examine Iceberg scan for metadata queries (NVIDIA#10836) Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add NVTX ranges to identify Spark stages and tasks (NVIDIA#10826) * Add NVTX ranges to identify Spark stages and tasks Signed-off-by: Jason Lowe <jlowe@nvidia.com> * scalastyle --------- Signed-off-by: Jason Lowe <jlowe@nvidia.com> --------- Signed-off-by: Haoyang Li <haoyangl@nvidia.com> Signed-off-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10831. This updates the Iceberg scan metadata tagging to catch exceptions when trying to examine the scan class, similar to how it catches exceptions when trying to convert a CPU scan to a GPU scan. This allows the plugin to gracefully fallback to the CPU even when we get class cast or other unexpected exceptions when trying to examine an Iceberg class that may not match what the plugin was compiled against.