Disable default cuDF pinned pool #10868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
changed the title
sameerz
added
the
task
abellina
added
bug
jlowe
approved these changes
May 23, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #10815 with one notable change.
Waiting for rapidsai/cudf#15815
The cuDF code is no longer going to throw when
configureDefaultCudfPinnedPoolSizefails. Instead it's going to return a boolean. If the boolean is true, we successfully disabled the cuDF default pool. Else, it will be false, and we will have 100MB of pinned pool around that we will not use, or we already have called this function ahead of time.I only anticipate this warning to show up in tests. We call this early enough and we only initialize once, so I don't think we'll ever see this in real life. Even in tests, we will set our own pinned resource, so we will use our own resource no matter what.