Building different Cuda versions section profile does not take effect [skip ci] #9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
kuhushukla
force-pushed
the
fix_contrib_cudaver_23.10
branch
from
fc8ecb3
to
1d3a4dd
Compare
gerashegalov
previously approved these changes
Sep 28, 2023
There was a problem hiding this comment.
LGTM
looks we removed these profiles in #3411 probably with the rationale that the profiles whose whole content is just one property do not add much value
gerashegalov
added
build
gerashegalov
changed the title
|
build |
abellina
reviewed
Sep 28, 2023
CONTRIBUTING.md
Outdated
| You can build against different versions of the CUDA Toolkit by using one of the following profiles: | ||
| * `-Pcuda11` (CUDA 11.0/11.1/11.2, default) | ||
| You can build against different versions of the CUDA Toolkit by modifying the variable `cuda.version`: | ||
| * `-Dcuda.version=cuda11` (CUDA 11.0/11.1/11.2, default) |
There was a problem hiding this comment.
nit,
Suggested change
| * `-Dcuda.version=cuda11` (CUDA 11.0/11.1/11.2, default) | |
| * `-Dcuda.version=cuda11` (set to `cuda11` for CUDA 11.x, or `cuda12` for CUDA 12.x) |
There was a problem hiding this comment.
cuda12 should be on a separate line. This already has the list-of-1 problem, so might as well lean into the fact that it's a list of values and add a new entry.
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
jlowe
approved these changes
Sep 28, 2023
gerashegalov
approved these changes
Sep 28, 2023
|
build |
abellina
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9327
No unit tests needed as it is a minor doc change.
I have one question regarding this change , whether we did intend having or had cuda versions as profiles in maven pom settings and if that is preferred over current change? CC: @gerashegalov