Skip redundant steps in nightly build [skip ci] #9857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
…ant-steps-in-nightly
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
also cc @sameerz @GaryShen2008, the best solution in my mind is still dropping trivial shims support, thanks |
|
build |
jlowe
approved these changes
Nov 27, 2023
gerashegalov
approved these changes
Nov 27, 2023
Yeah, I have the same for my local ENV. We can consider having a minimal profile for nightly builds in the future to remove all trivial works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we currently have 22 shims in nightly build, the entire build+deploy (not including tests) time is close to 7 hours now.
To reduce the time cost, this change is trying to skip redundant scala style + scala doc (vary from 30s to 5mins per submodule build) steps while deploy commands.
After this change the duration is ~ 5hours (saves 2 hours)
Also added TODO to not deploy all non-dist submodules to try save more deploying time (currently 8-10min per shim)
This could be
aggregator,sql-plugin-api,integration-tests, please correct me if I miss any @jlowe @revans2 @tgravescs @gerashegalov thanksVerified internally. [skip ci] as it would not be covered in pre-merge.