Register default allocator for host memory #9908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
1 similar comment
|
build |
|
build |
|
build |
jbrennan333
previously approved these changes
Dec 1, 2023
|
build |
abellina
reviewed
Dec 4, 2023
| @@ -163,6 +163,9 @@ private class HostAlloc(nonPinnedLimit: Long) extends HostMemoryAllocator with L | |||
| var allocAttemptFinishedWithoutException = false | |||
| try { | |||
| do { | |||
| if (retryCount > 0) { | |||
| logWarning(s"RETRY HOST ALLOC $amount $preferPinned $blocking $retryCount") | |||
There was a problem hiding this comment.
did you want to leave this as warn?
|
build |
abellina
approved these changes
Dec 4, 2023
sameerz
added
the
reliability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us to a point where we can have CUDF java allocating host memory through HostAlloc. But it is not 100% perfect yet. Test pass, but the integration tests appear to have a live lock in them that I need to track down when running with limited memory. It should still be good for us to get started working on other HostMemoryLimit issues.