Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cases for cast between integral and (date/time) #9957

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update cases for cast between integral and (date/time) #9957

merged 1 commit into from
Dec 6, 2023

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Dec 5, 2023

contributes to #6839

  • cast between integral and timestamp: it's not time zone related, just update test case.
  • cast from date to integral: returns all null, it's not time zone related, just update test case.
  • cast from integral to date: not allowed.

Signed-off-by: Chong Gao res_life@163.com

Update cases for cast between integral and (date/time)
a15fa1c 
Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

res-life commented Dec 5, 2023

build

revans2
revans2 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine. Were they run under another time zone to be sure everything works as expected?

@sameerz sameerz added the test Only impacts tests label Dec 5, 2023
@res-life
Copy link
Collaborator Author

res-life commented Dec 6, 2023

These look fine. Were they run under another time zone to be sure everything works as expected?

Yes, verified the Iran TZ on Spark311 and Spark330.

@res-life res-life merged commit ae41666 into NVIDIA:branch-24.02 Dec 6, 2023
39 checks passed
@res-life res-life deleted the cast_integral branch December 6, 2023 02:10
@revans2 revans2 mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@res-life @revans2 @sameerz