Feature/cuda reduce #1064
Draft
Feature/cuda reduce #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZelboK
commented
Sep 4, 2023
|
|
||
| // this is basically the apply function that sender_apply is looking for. | ||
| template <class S, class Fn> | ||
| auto plscompile(S s, Fn f) { |
There was a problem hiding this comment.
This should be renamed to apply. I was conducting an experiment.
ZelboK
commented
Sep 4, 2023
include/nvexec/stream_context.cuh
Outdated
| auto transformed = reduce_sender_t<decltype(sender), decltype(initT), decltype(fun)>( | ||
| {}, sender, initT, fun); | ||
| return transformed; | ||
| }; |
There was a problem hiding this comment.
Some thoughts:
- Does the fact that hte compiler no longer complains about hte errors related to
__on::receiver_refnot having a call operator thus indicate that the tree has been fully transformed, children and alike? I was going off of this assumption.
transform_sender will rely on this specialization of reconstitute for every sender alongside their children. Now one caveat is... Am I not transforming the entire tree? If that's the case, wouldn't there be an error similar to the 1st point? The fact htat it's looking for an apply function, does that not indicate it has transformed the tree properly?
ZelboK
commented
Sep 4, 2023
include/nvexec/stream_context.cuh
Outdated
| (Sender&&) sndr, | ||
| [&]<class Tag, class Data, class... Children>(Tag, Data&& data, Children... children) { | ||
| if constexpr (sizeof...(Children) == 0) { | ||
| return sndr; |
|
/ok to test |
fix cycle in type system in stream scheduler concepts
ericniebler
force-pushed
the
feature/cuda_reduce
branch
from
66cbfbf
to
b240e36
Compare
ericniebler
force-pushed
the
feature/cuda_reduce
branch
from
f8c27c5
to
6dce716
Compare
ericniebler
force-pushed
the
feature/cuda_reduce
branch
2 times, most recently
from
c16e048
to
d97b5df
Compare
|
/ok to test |
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.