Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests and installing Catch2 if in a subproject #1313

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

planetmarshall
Copy link
Contributor

Catch2 is still installed if stdexec is used as a subproject. This can cause issues if Catch2 is already installed by the parent project. Also disable the building of tests by default if using as a subproject.

Copy link

copy-pr-bot bot commented Apr 27, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler
Copy link
Collaborator

/ok to test

@ericniebler ericniebler merged commit f808f70 into NVIDIA:main Apr 29, 2024
18 checks passed
@ericniebler
Copy link
Collaborator

Thanks! I'm grateful for any help I can get, but especially CMake help.

@planetmarshall
Copy link
Contributor Author

Thanks! I'm grateful for any help I can get, but especially CMake help.

No problem. I hope to make more substantial contributions in the future but still getting to grips with the sender/receiver pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants