Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

cmake: print status message if Thrust is found #1300

Merged
merged 1 commit into from
Oct 15, 2020
Merged

cmake: print status message if Thrust is found #1300

merged 1 commit into from
Oct 15, 2020

Conversation

germasch
Copy link
Contributor

@germasch germasch commented Oct 1, 2020

Here's a minor improvement to the cmake config that's installed with Thrust:

If using find_package(Thrust 1.10.0) is successful, it'll print something like

-- Found Thrust: /root/src/thrust/build/install/include/thrust/cmake/thrust-config.cmake (found suitable version "1.11.0.0", minimum required is "1.10.0")

rather than being silent about it.

@alliepiper
Copy link
Collaborator

LGTM

@alliepiper alliepiper self-assigned this Oct 1, 2020
@alliepiper alliepiper added this to Inbox in PR Tracking via automation Oct 1, 2020
@alliepiper alliepiper moved this from Inbox to Needs Testing [PRs] in PR Tracking Oct 1, 2020
@alliepiper alliepiper added this to the 1.11.0 milestone Oct 1, 2020
@alliepiper alliepiper added the only: cmake CMake changes only. Doesn't need internal NVIDIA CI. label Oct 1, 2020
@alliepiper alliepiper moved this from Needs Testing [PRs] to Integration [PRs] in PR Tracking Oct 5, 2020
@alliepiper alliepiper added the blocked Cannot make progress. label Oct 5, 2020
@alliepiper
Copy link
Collaborator

Blocked pending CUB changes.

@alliepiper alliepiper removed the blocked Cannot make progress. label Oct 15, 2020
@alliepiper alliepiper merged commit 773f207 into NVIDIA:main Oct 15, 2020
PR Tracking automation moved this from Integration [PRs] to Done Oct 15, 2020
@germasch germasch deleted the pr/cmake-found-message branch October 15, 2020 18:44
alliepiper added a commit to alliepiper/cub that referenced this pull request Oct 15, 2020
@alliepiper
Update CUB CMake to match recent changes to Thrust.
cc2870a 
Specifically, this ports the following PRs to CUB:

- NVIDIA/thrust#1297 Add install rule option for add_subdirectory users.
- NVIDIA/thrust#1298 Enforce semantic versioning in CMake version configs.
- NVIDIA/thrust#1300 Use FindPackageHandleStandardArgs in CMake config.
@alliepiper alliepiper mentioned this pull request Oct 15, 2020
Merged
alliepiper added a commit to NVIDIA/cub that referenced this pull request Oct 19, 2020
@alliepiper
Update CUB CMake to match recent changes to Thrust.
ea48955 
Specifically, this ports the following PRs to CUB:

- NVIDIA/thrust#1297 Add install rule option for add_subdirectory users.
- NVIDIA/thrust#1298 Enforce semantic versioning in CMake version configs.
- NVIDIA/thrust#1300 Use FindPackageHandleStandardArgs in CMake config.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees

@alliepiper alliepiper

Labels
only: cmake CMake changes only. Doesn't need internal NVIDIA CI.
Projects
PR Tracking
Done
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germasch @alliepiper