This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Variadic make zip iterator #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is independent of #1310, please rebase the branch to remove the overlapping commits. This will greatly simplify reviewing, testing, and integration. |
alliepiper
suggested changes
Oct 12, 2020
andrewcorrigan
force-pushed
the
variadic-make-zip-iterator
branch
from
5c5551c
to
752e19b
Compare
|
Done. |
|
Thanks! LGTM, I'll start tests on this soon. |
andrewcorrigan
force-pushed
the
variadic-make-zip-iterator
branch
from
752e19b
to
c59b1db
Compare
|
I just pushed a commit that switches back to 2 spaces of indentation (the original commit gratuitously changed from 2 to 4). |
|
Heh, yeah. I probably wouldn't have noticed the indentation :) We really need to pick a style and stick with it for Thrust and CUB. DVS CL 29194412. |
alliepiper
added
testing: internal ci in progress
alliepiper
added
testing: gpuCI passed
alliepiper
approved these changes
Oct 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit [5c5551c] would resolve #663 . This is not dependent on the commits prior (already submitted via #1310), I just ended up committing it after those.