Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix type is_pod trait for GCC 10.2. #1338

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

tomilov
Copy link
Contributor

@tomilov tomilov commented Nov 7, 2020

Currently for __GNUC__ == 10 and __GNUC_MINOR__ == 2 second part of condition (__GNUC__ >= 4) && (__GNUC_MINOR__ >= 3) is false. Whole condition expected to be true. For that lexicographical comparison is needed. Something with aid like this.

Currently it is impossible to construct thrust::device_vector<S> from std::vector<S>, when host compiler is g++ from GCC 10.2:

struct S { int i; };
static_assert(std::is_trivially_destructible_v<S>, "!");
std::vector<S> u{S{1}, S{2}, S{3}};
thrust::cuda::vector<S> v{u.cbegin(), u.cend()};

due to wrong SFINAE picking on this line (which in fact must be enable_if_destroy_range_case3) which result in error starting from thrust::cuda::vector<S>::~vector destructor.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@tomilov
Copy link
Contributor Author

tomilov commented Nov 7, 2020

Can one of the admins verify this patch?

feel free to call them.

@alliepiper
Copy link
Collaborator

Good catch, we should be able to get this in for 1.11.0.

We should also make it clearer in those GPUtester comments that they're coming from a bot :)

@alliepiper alliepiper added this to Inbox in PR Tracking via automation Nov 9, 2020
@alliepiper alliepiper moved this from Inbox to Needs Testing [PRs] in PR Tracking Nov 9, 2020
@alliepiper alliepiper added this to the 1.11.0 milestone Nov 9, 2020
@alliepiper alliepiper self-assigned this Nov 9, 2020
@alliepiper alliepiper moved this from Needs Testing [PRs] to Tests Pending [PRs] in PR Tracking Nov 9, 2020
@alliepiper alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Nov 9, 2020
@alliepiper
Copy link
Collaborator

DVS CL: 29301117

@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Nov 10, 2020
@alliepiper alliepiper moved this from Tests Pending [PRs] to Integration [PRs] in PR Tracking Nov 10, 2020
@alliepiper alliepiper merged commit 84219dc into NVIDIA:main Nov 11, 2020
PR Tracking automation moved this from Integration [PRs] to Done Nov 11, 2020
@alliepiper
Copy link
Collaborator

All set. Thanks for the patch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants