Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix signbit(double) implementation on MSVC. #1388

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Fix signbit(double) implementation on MSVC. #1388

merged 1 commit into from
Feb 22, 2021

Conversation

alliepiper
Copy link
Collaborator

Likely related to pytorch/pytorch#52299.

@alliepiper alliepiper mentioned this pull request Feb 19, 2021
Closed
@alliepiper alliepiper added the type: bug: functional Does not work as intended. label Feb 19, 2021
@alliepiper alliepiper added this to Inbox in PR Tracking via automation Feb 19, 2021
@alliepiper alliepiper moved this from Inbox to Need Review in PR Tracking Feb 19, 2021
@alliepiper
Copy link
Collaborator Author

DVS CL 29629939

@alliepiper alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Feb 19, 2021
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper added this to the 1.12.0 milestone Feb 19, 2021
@alliepiper alliepiper moved this from Need Review to Tests Pending in PR Tracking Feb 19, 2021
@mszhanyi mszhanyi mentioned this pull request Feb 20, 2021
Closed
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Feb 22, 2021
@alliepiper alliepiper moved this from Tests Pending to Integration in PR Tracking Feb 22, 2021
@alliepiper alliepiper merged commit 347988d into NVIDIA:main Feb 22, 2021
PR Tracking automation moved this from Integration to Done Feb 22, 2021
@alliepiper alliepiper deleted the fix_complex_signbit_msvc branch February 22, 2021 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brycelelbach brycelelbach brycelelbach approved these changes

Assignees
No one assigned
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). type: bug: functional Does not work as intended.
Projects
PR Tracking
Done
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alliepiper @brycelelbach