Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

copy_if doesn't require copy assignment operator for OutputIterator #1756

Merged
merged 3 commits into from
Jul 28, 2022
Merged

copy_if doesn't require copy assignment operator for OutputIterator #1756

merged 3 commits into from
Jul 28, 2022

Conversation

mfbalin
Copy link
Contributor

@mfbalin mfbalin commented Jul 27, 2022

For OutputIterators who don't have copy assignment operator, the assignment into result was giving a compiler error. This change avoids using the copy assignment operator.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

alliepiper
alliepiper suggested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable, but go ahead and remove the return statement following the THRUST_CDP_DISPATCH macro -- compilers will flag that as unreachable code and emit warnings.

@alliepiper alliepiper added type: bug: functional Does not work as intended. P1: should have Necessary, but not critical. backend: CUDA Related to the CUDA backend labels Jul 27, 2022
@alliepiper alliepiper added this to the 2.0.0 milestone Jul 27, 2022
@alliepiper alliepiper added this to Inbox in PR Tracking via automation Jul 27, 2022
@alliepiper
Copy link
Collaborator

run tests

@alliepiper alliepiper moved this from Inbox to Tests Pending in PR Tracking Jul 27, 2022
@alliepiper alliepiper added the testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). label Jul 27, 2022
miscco
miscco approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for that contribution! 🎉

@alliepiper
Copy link
Collaborator

run tests

@alliepiper alliepiper merged commit 34a9562 into NVIDIA:main Jul 28, 2022
PR Tracking automation moved this from Tests Pending to Done Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

@miscco miscco miscco approved these changes

Assignees
No one assigned
Labels
backend: CUDA Related to the CUDA backend P1: should have Necessary, but not critical. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). type: bug: functional Does not work as intended.
Projects
PR Tracking
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfbalin @GPUtester @alliepiper @miscco