Use real mount points #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would create one loopback device with some subdirs to represent "drives" and symlink them into place under /srv/node* Now, use N loopback devices. Note that you may want to crank down LOOPBACK_GB as it applies to each sparse file and the default may allow you to fill your VM's root disk. Two side benefits (beyond getting closer to "real" system behavior): we can now enable mount_check, and we can have per-node-and-service rsync modules. Addresses #43.
|
Tested on Bionic -- haven't tried some of the other base images we might want to support. |
Closed
|
Oh hey, there's also #21... |
|
I'd say this would close #43 I tested it and it works good for me on xenial & bionic |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would create one loopback device with some subdirs to represent "drives" and symlink them into place under
/srv/node*Now, use N loopback devices. Note that you may want to crank down
LOOPBACK_GBas it applies to each sparse file and the default may allow you to fill your VM's root disk. (Not immediately -- the files are still sparse -- but PUT enough data and you'll fill up.)Two side benefits (beyond getting closer to "real" system behavior):