Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Windows locale is Japanese, About these header files, Visual C++ treats C4819 as compile error. Because, when it happens that Visual C++ compiles UTF-8 files without BOM as cp932 encoding on Japanese locale.
These header files are external, it modified is difficult, and future, more files may be.
Files:
1.Falcor\external\packman\nanovdb\include\nanovdb\NanoVDB.h
2.Falcor\external\packman\deps\include\FreeImage.h
Error Messages (include Japanese):
Falcor\external\packman\nanovdb\include\nanovdb/NanoVDB.h(1,1): error C2220: 次の警告はエラーとして処理されます Falcor\external\packman\nanovdb\include\nanovdb/NanoVDB.h(1,1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
Falcor\external\packman\deps\include\FreeImage.h(1,1): error C2220: 次の警告はエラーとして処理されます
Falcor\external\packman\deps\include\FreeImage.h(1,1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
Every time Falcor has added a version, I have added C4819.
Probably all users in Japan have done so.
So, I make pull request that it disabled warning C4819 on VC Projects.
Best regards.