Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pycuda with cuda-python calls #105

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

orperel
Copy link
Collaborator

@orperel orperel commented Jan 15, 2023

This change-set deprecates the pycuda usage, which complicated the Wisp installation due to GL extension compilation.
Requires pip install cuda-python

Changes:

  • pycuda replace with direct cuda api (cuda-python bindings)
  • cuda_guard.py have been removed (no longer needed as context bugs are bypassed)
  • GLX error messages when closing windows are now gone.
  • Support for torch 1.9.1 is fixed.
  • pycuda can be used as a fallback by setting the env variable ENABLE_PYCUDA=1
  • Fix support for WSL through bypassing cuda-opengl interop.

New Wisp installation:

pip install -r requirements.txt
pip install -r requirements_app.txt
python setup.py develop

Signed-off-by: operel operel@nvidia.com

cuda guard changes

First runnable version without pycuda

Add cuda-python to requirements.txt

cuda module

add pycuda fallback, remove cuda_guard

Missing torch import

Enable wisp for torch 1.9.1

Signed-off-by: operel <operel@nvidia.com>

Fix deallocation of handles

Fix WSL compatability

Signed-off-by: operel <operel@nvidia.com>

Update install instructions

Updated INSTALL.md

Signed-off-by: operel <operel@nvidia.com>
@orperel orperel merged commit 351a04a into NVIDIAGameWorks:main Jan 17, 2023
@orperel orperel mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant