Remove pidx from interpolate and raymarching output #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reformatted nefs with less constraints num_lods references updated from nef to nef.grid remove hashgrid num_samples default for raymarch MR fixes for part 3 Signed-off-by: operel <operel@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the neural fields: a simpler interface without kwargs, and less assumptions on the nef initialization.
The MR also simplifies some of the PE initialization / forward logic by introducing properties.
Some pos / view embedding paths which were unusable have now been restored.
Signed-off-by: operel operel@nvidia.com