Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated grid + AS api #85

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

orperel
Copy link
Collaborator

@orperel orperel commented Dec 20, 2022

Originally, Triplanar grid used a single level-octree as an acceleration structure, essentially an AABB.
Since we treated that accelstruct as an octree everywhere that caused some edge cases issues with the gui (i.e. triplane wouldn't draw any layers at all).
In addition - the datalayers erroneously operated on BLASGrids and not the acceleration structs (the version we have right now draws information about occupancy).

This MR:

  1. Fixes errors in the design of the datalayers
  2. Fixes the datalayer issues that Triplane had before (makes sure AABB has drawable layers)
  3. Fixes how blas-grid / accelstruct names are passed everywhere, this is now more general (the previous if-else way was brittle)

Fix datalayers for octree and aabb accelstructs

Signed-off-by: operel <operel@nvidia.com>
@orperel orperel merged commit 0d219d3 into NVIDIAGameWorks:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant