Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operel/mvdataset docker qol #86

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

orperel
Copy link
Collaborator

@orperel orperel commented Dec 20, 2022

Quality of life improvements, these are all small local changes fit together:

  • docker issue: bumpy spicy version to >=1.7.2 (user complaints on github)
  • fix issue with validation splits missing in standard nerf (fix was in place and removed, restored here)
  • ensure all dataset fields are declared in ctor
  • basic decoder support for layer type ‘linear’ -> nn.Linear (previously was only called ‘none’ in config)
  • offline renderer doesn’t assume matcap by default (which is specific to sdf pipelines right now)

operel added 3 commits December 20, 2022 20:58
avoid double init for datasets

Signed-off-by: operel <operel@nvidia.com>
@orperel orperel merged commit 7b1516c into NVIDIAGameWorks:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant