Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseAS interface #99

Merged
merged 1 commit into from
Jan 10, 2023
Merged

BaseAS interface #99

merged 1 commit into from
Jan 10, 2023

Conversation

orperel
Copy link
Collaborator

@orperel orperel commented Jan 10, 2023

This pull request adds the BaseAS abstract, to unify the upcoming acceleration structures under a single interface.

Notably raymarch / raytrace / query now return dataclasses of results. This is desired because:

  1. It allows to easily handle and pass around the various return values from these functions
  2. In case some raymarch ops return other output formats in the future, we could more easily enforce it by querying the dataclass return type

Signed-off-by: operel <operel@nvidia.com>
@orperel orperel merged commit 2db0328 into NVIDIAGameWorks:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant