Increase minimum PyTorch requirements to 1.2.0 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we testing |
|
@Caenorst Testing |
|
Do we actually want to have an assertion ? Why not just having a warning message ? I agree that we don't wanna officially support old version of Pytorch / CUDA / python but should we explicitly make the installation crash while it could potentially works ? |
|
I agree. A warning is better than crashing the installation. Fixed. |
Caenorst
approved these changes
Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#65
Testing PyTorch versions (before changes)
PyTorch 0.4.1, CUDA 9
pytorch/pytorch:0.4.1-cuda9-cudnn7-develfatal error: torch/extension.h: No such file or directory)PyTorch 1.0, CUDA 10.0
pytorch/pytorch:1.0-cuda10.0-cudnn7-develerror: 'TORCH_CHECK' was not declared in this scope)PyTorch 1.1.0, CUDA 10.0
pytorch/pytorch:1.1.0-cuda10.0-cudnn7.5-develerror: 'TORCH_CHECK' was not declared in this scope)PyTorch 1.2, CUDA 9.2
nvidia/cuda:9.2-base-ubuntu16.04error: command '/usr/local/cuda/bin/nvcc' failed with exit status 1)PyTorch 1.2, CUDA 10.0
pytorch/pytorch:1.2-cuda10.0-cudnn7-develTests (after changes)
pytorch/pytorch:1.2-cuda10.0-cudnn7-develpytorch/pytorch:1.0.1-cuda10.0-cudnn7-devel