Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hit/Destroy Player Action #31

Closed
bboudaoud-nv opened this issue Jul 11, 2019 · 1 comment
Closed

Hit/Destroy Player Action #31

bboudaoud-nv opened this issue Jul 11, 2019 · 1 comment
Assignees
@jspjutNV @joohwankimNV @bboudaoud-nv
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@bboudaoud-nv
Copy link
Collaborator

As we implemented multiple targets towards issue #28, we broke the accumulation of the hit and destroy player actions (these seem to be recorded as non-task?). We should look into this and get it working again.
@bboudaoud-nv bboudaoud-nv added bug Something isn't working invalid This doesn't seem right labels Jul 11, 2019
@bboudaoud-nv
Copy link
Collaborator Author

This was the result of some sloppy pointer work in the App::fire() method, which has been greatly simplified as of a recent commit. hit and destroy actions now appear just fine in the Player_Action log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jspjutNV jspjutNV

@joohwankimNV joohwankimNV

@bboudaoud-nv bboudaoud-nv

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jspjutNV @joohwankimNV @bboudaoud-nv