Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGGRAPH Asia 2019 Sample Experiments #347

Merged
merged 9 commits into from Feb 8, 2022
Merged

SIGGRAPH Asia 2019 Sample Experiments #347

merged 9 commits into from Feb 8, 2022

Conversation

jspjutNV
Copy link
Contributor

@jspjutNV jspjutNV commented Feb 2, 2022

This PR includes sample experiments originally used for the SIGGRAPH Asia 2019 paper updated to use the latest versions of FPSci.

It also includes updates to the sample experiment contribution instructions.

@jspjutNV jspjutNV added the enhancement New feature or request label Feb 2, 2022
@jspjutNV jspjutNV added this to the v21.11 milestone Feb 2, 2022
@jspjutNV jspjutNV self-assigned this Feb 2, 2022
@jspjutNV jspjutNV added this to To Do in Issue Tracking via automation Feb 2, 2022
@jspjutNV jspjutNV changed the title Sample contribution instructions SIGGRAPH Asia 2019 Sample Experiments Feb 2, 2022
@bboudaoud-nv
Copy link
Collaborator

I have made some minor corrections to whitespace formatting and specified the scene name (as you always should when applying position/heading).

However, I think there are still significant differences between this configuration and what was used for the SIGA 2019 study. I've included our screenshot from the SIGA paper below for reference

Original
image

Current Version
image

Note that:

  1. We are not using the same type of cooldown indicator (may be okay)
  2. The click-to-photon monitor appears to be on the wrong side (left)
  3. The click-to-photon monitor is 2 drastically different sizes between the experiments (track shown in screenshot above seems better)
  4. The reticle is a different color (green vs red)
  5. The reticle seems substantially larger (by factor of 2x or more)
  6. The reference target seems marginally smaller

@bboudaoud-nv
Copy link
Collaborator

In addition the config file itself seems to be using a mix of syntax that might be confusing for new users to FPSci, this includes:

  1. Use of , and ; to end lines
  2. Use of = and : in assignment
  3. Use of (...) and [...] list conventions
  4. Parameter names with and without quotes around them

…ze. Verified track experiment target distance was as in the original SA2019 study.
@bboudaoud-nv
Copy link
Collaborator

@joohwankimNV overall these changes are looking really good. My only other suggestion is that if we want to we could introduce an sa2019_sampleuser that does reticle scale/color rather than updating the default user. Alternatively we could just keep with your approach of updating the global Sample User.

You could add:

  reticleColor = [Color4(0,1,0,1), Color4(0,1,0,1)];

to the user config to make the reticle green if you'd like. I'm not sure how important target/reticle contrast is overall, but I don't see a downside to more closely matching the experiment.

@jspjutNV
Copy link
Contributor Author

jspjutNV commented Feb 8, 2022

I'm going to merge this despite not being "approved" since the only remaining issue was fixed by Joohwan and we really need to get the release out. If you want to post-approve it still Ben, feel free.

I'll leave the branch for you to delete once approved.

@jspjutNV jspjutNV merged commit 223b70c into master Feb 8, 2022
Issue Tracking automation moved this from To Do to Done Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants