Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference target model config #354

Merged
merged 2 commits into from Apr 11, 2022
Merged

Conversation

bboudaoud-nv
Copy link
Collaborator

@bboudaoud-nv bboudaoud-nv commented Mar 31, 2022

This branch adds support for configuring the overall and per-session reference target model using a new referenceTargetModelSpec general configuration parameter. This field takes an ArticulatedModel::Specification just as all other model specification in our config files.

Just like all other general configuration this can be specified at the experiment-level and/or overwritten at the per-session level.

Currently this branch does not change the default reference target shape.

@bboudaoud-nv bboudaoud-nv added the enhancement New feature or request label Mar 31, 2022
@bboudaoud-nv bboudaoud-nv self-assigned this Mar 31, 2022
@bboudaoud-nv bboudaoud-nv changed the title Add and document reference target model config Add reference target model config Mar 31, 2022
@bboudaoud-nv bboudaoud-nv marked this pull request as ready for review April 4, 2022 21:58
@jspjutNV jspjutNV added this to the Next Release (mid 2022) milestone Apr 7, 2022
Copy link
Contributor

@jspjutNV jspjutNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass

@jspjutNV jspjutNV merged commit 932e53f into master Apr 11, 2022
@jspjutNV jspjutNV deleted the ReferenceTargetModelConfig branch April 11, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants